Skip to content

[MEX-961] code quality improvements#1757

Merged
claudiulataretu merged 14 commits intofeat/state-rpcfrom
MEX-961-fixes-after-testing
Apr 6, 2026
Merged

[MEX-961] code quality improvements#1757
claudiulataretu merged 14 commits intofeat/state-rpcfrom
MEX-961-fixes-after-testing

Conversation

@claudiulataretu
Copy link
Copy Markdown
Collaborator

@claudiulataretu claudiulataretu commented Apr 6, 2026 •
edited
Loading

Reasoning

  • missing unit tests for state rpc microservice
  • small fixes on compute services
  • state cron jobs started before state-rpc was initialized
  • token price compute in bulk service missed the common tokens check

Proposed Changes

  • Added more unit tests for state-rpc microservice covering all handlers and computes
  • Added common tokens check in bulk service token compute
  • Added a initialized rpc method for state-rpc to check it's state before executing cron jobs
  • small fixes on staking compute service and fees collector missing week compute in state-rpc

How to test

  • All unit tests should pass

@claudiulataretu
MEX-961: added debug log message
3e6aaeb 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: fix empty identifier guard and deduplication in StateStore
d1c3e53 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: add test utilities and compute service mocks for dex-state s…
e9057f6 
…pecs

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: add unit tests for StateStore
c04d362 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: add unit tests for state handlers (tokens, pairs, farms, sta…
058797f 
…king, fees-collector, timekeeping)

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: add unit tests for BulkUpdatesService
0603058 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: add unit tests for StateTasksService
9baa4c9 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: added missing fees collector compute in state-rpc
c871293 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: fix USD values computes in bulk updates
80763c1 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: added state rpc ready check endpoint
a21aeaf 
- check for state rpc readiness before executing cron jobs fron state cron

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: fix staking undistributed rewards compute
a66bb4f 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: added in-depth performance profiler for state sync
1d0737b 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: removed logging messages
2ce103f 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu
MEX-961: fix failed unit tests
7bd5735 
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.36641% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.08%. Comparing base (c664ac9) to head (7bd5735).
⚠️ Report is 16 commits behind head on feat/state-rpc.

Files with missing lines Patch % Lines
src/modules/state/services/state.sync.service.ts 0.00% 14 Missing ⚠️
...services/compute/fees-collector.compute.service.ts 33.33% 2 Missing ⚠️
...odules/staking/services/staking.compute.service.ts 0.00% 2 Missing ⚠️
src/modules/state/services/state.service.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           feat/state-rpc    #1757      +/-   ##
==================================================
+ Coverage           54.44%   56.08%   +1.63%     
==================================================
  Files                 304      334      +30     
  Lines               14567    16627    +2060     
  Branches             1928     2403     +475     
==================================================
+ Hits                 7931     9325    +1394     
- Misses               6630     7296     +666     
  Partials                6        6
Flag Coverage Δ
unittests 56.08% <92.36%> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claudiulataretu claudiulataretu merged commit 980c827 into feat/state-rpc Apr 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioandanpopa ioandanpopa ioandanpopa approved these changes

@psorinionut psorinionut psorinionut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@claudiulataretu @ioandanpopa @psorinionut